Fixed and improved history window closing#39
Merged
moyiz merged 1 commit intomoyiz:masterfrom Apr 13, 2026
Merged
Conversation
Owner
|
Thanks for taking the time to create a PR.
diff --git i/lua/git-dev/pickers/init.lua w/lua/git-dev/pickers/init.lua
index 38985bf..ac11b70 100644
--- i/lua/git-dev/pickers/init.lua
+++ w/lua/git-dev/pickers/init.lua
@@ -29,13 +29,15 @@ local P = {
end,
-- Action on selection
select_entry = function(entry)
- if entry then
- require("git-dev").open(
- entry.args.repo,
- entry.args.ref,
- entry.args.opts
- )
- end
+ vim.schedule(function()
+ if entry then
+ require("git-dev").open(
+ entry.args.repo,
+ entry.args.ref,
+ entry.args.opts
+ )
+ end
+ end)
end,
-- An array of an entry text parts
label_parts = function(entry)
|
jaynis
force-pushed
the
fix/close-history-window
branch
from
590d865 to
e74d93b
Compare
Contributor
Author
|
|
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
moyiz
force-pushed
the
fix/close-history-window
branch
from
e74d93b to
8de07d5
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the history picker window closing by adding a small delay and fixed the issue where the window remained visible when selecting a repository in an non-telescope picker.
Changes:
picker:close()), Mini.pick (minipick.stop()), and vim.ui.select pickersselect_entry()for all pickers (Snacks, Telescope, Mini.pick, vim.ui.select) to process the close commands and ensure a clean visual transitionCloses #38